feat/revocation endpoint auth methods#6
Merged
Conversation
Adds two private helpers, captureStreamBody() and captureAuthHeader() that build stub factories returning a callback-based capture. Five existing tests use them, dropping ~30 lines of duplicated stub setup.
New optional revocationEndpointAuthMethodsSupported field on ProviderConfig. As of RFC 8414 §2 OAuth2Client::revokeToken() uses it for client authentication selection when present or falls back to tokenEndpointAuthMethodsSupported per the spec's specified default. If both are missing, implies POST method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor follow up to @jcdelepine's #5
The RFC allows a separate advertising field for the revocation endpoint auth methods. If not present, reuse the authentication endpoint as in #5